RFR: 8368977: Provide clear naming for AVX10 identifiers [v2]
Mohamed Issa
missa at openjdk.org
Mon Dec 8 21:47:19 UTC 2025
On Mon, 8 Dec 2025 03:28:59 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Mohamed Issa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove changes that affect functionality
>
> src/hotspot/cpu/x86/templateTable_x86.cpp line 1605:
>
>> 1603: __ jcc(Assembler::notEqual, L);
>> 1604: __ call_VM_leaf(CAST_FROM_FN_PTR(address, SharedRuntime::f2i), 1);
>> 1605: }
>
> This change should be part of a seperate PR.
Sure, I'll cover this in another PR.
> src/hotspot/cpu/x86/templateTable_x86.cpp line 1620:
>
>> 1618: __ jcc(Assembler::notEqual, L);
>> 1619: __ call_VM_leaf(CAST_FROM_FN_PTR(address, SharedRuntime::f2l), 1);
>> 1620: }
>
> Please restrict this PR to name change related changes only.
I reverted changes to this file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28344#discussion_r2600243093
PR Review Comment: https://git.openjdk.org/jdk/pull/28344#discussion_r2600244394
More information about the hotspot-dev
mailing list