RFR: 8372348: Adjust some UL / JFR string deduplication output messages
Matthias Baesken
mbaesken at openjdk.org
Wed Dec 10 14:26:33 UTC 2025
On Mon, 24 Nov 2025 08:20:09 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> src/hotspot/share/gc/shared/stringdedup/stringDedupStat.cpp line 218:
>>
>>> 216: log_debug(stringdedup)(" Known: %12zu(%5.1f%%)", _known, known_percent);
>>> 217: log_debug(stringdedup)(" Shared: %12zu(%5.1f%%)", _known_shared, known_shared_percent);
>>> 218: log_debug(stringdedup)(" New unknown: %12zu(%5.1f%%)" STRDEDUP_BYTES_FORMAT,
>>
>> I'm wondering if just `Unknown` would be more self-explanatory than `New unknown`? We have `Known` already, and `New unknown` is the complement of `Known`
>
> Maybe , but the variables are named `_new / _new_bytes` and the JFR fields also have 'new' in the name. So it maybe makes sense to keep 'new' in the UL and related output.
The avg (now named total avg) is for some people also a bit mysterious .
It is , taken from total_stat , the` deduped bytes / new bytes` . Why is it called avg? avg of what ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28455#discussion_r2606867602
More information about the hotspot-dev
mailing list