RFR: 8371948: TestStackOverflowDuringInit.java fails xss too small on linux-aarch64 [v4]
SendaoYan
syan at openjdk.org
Thu Dec 11 02:11:25 UTC 2025
On Wed, 10 Dec 2025 07:46:27 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Use jlong instead of jint
>
> src/hotspot/share/runtime/os.cpp line 2580:
>
>> 2578: }
>> 2579:
>> 2580: jlong os::get_minimum_java_stack_sizes() {
>
> Suggestion:
>
> jlong os::get_minimum_java_stack_size() {
Fixed.
> src/hotspot/share/runtime/os.hpp line 394:
>
>> 392: public:
>> 393: // get allowed minimum java stack sizes
>> 394: static jlong get_minimum_java_stack_sizes();
>
> Suggestion:
>
> // get allowed minimum java stack size
> static jlong get_minimum_java_stack_size();
Thanks. `get_minimum_java_stack_sizes` has been replaced as `get_minimum_java_stack_size`.
> test/hotspot/jtreg/runtime/memory/ReadMinimumJavaStackSize.java line 1:
>
>> 1: /*
>
> We don't need a test to exercise the WhiteBox API explicitly.
Okey. The new test test/hotspot/jtreg/runtime/memory/ReadMinimumJavaStackSize.java has been removed.
> test/lib/jdk/test/whitebox/WhiteBox.java line 80:
>
>> 78: public native long getHeapSpaceAlignment();
>> 79: public native long getHeapAlignment();
>> 80: public native long getMinimumJavaStackSize();
>
> Suggestion:
>
> public native long getMinimumJavaStackSize();
Thanks. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28352#discussion_r2608861966
PR Review Comment: https://git.openjdk.org/jdk/pull/28352#discussion_r2608861218
PR Review Comment: https://git.openjdk.org/jdk/pull/28352#discussion_r2608863514
PR Review Comment: https://git.openjdk.org/jdk/pull/28352#discussion_r2608862645
More information about the hotspot-dev
mailing list