RFR: 8351889: C2 crash: assertion failed: Base pointers must match (addp 344) [v5]

[Roland Westrelin]

On Thu, 11 Dec 2025 14:29:16 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/opto/phaseX.cpp line 2070:
> 
>> 2068:     if (addp->is_AddP() &&
>> 2069:         !addp->in(AddPNode::Base)->is_top() &&
>> 2070:         addp->in(AddPNode::Base) != n->in(AddPNode::Base)) {
> 
> Any way we could avoid this code duplication with the same check in `Compile::final_graph_reshaping_main_switch`?

I pushed a new commit. Is it what you had in mind?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25386#discussion_r2611166125