RFR: 8372845: C2: Fold identity hash code if object is constant [v3]

Vladimir Ivanov vlivanov at openjdk.org
Sat Dec 13 01:00:52 UTC 2025


On Thu, 11 Dec 2025 07:19:24 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> It's a test on C2 IR. What's the point in running it w/o C2?
>
> You can always do more than just C2 IR verification. For example, we could also do result verification. That would give us coverage for C1 for example. I think it is just good practice not to have a restriction if it is not absolutely necessary.

I don't argue that there's always a chance to catch a bug, but unit tests on C2 IR are mostly trivial, so the actual chance to spot a unique problem is quite low. And the price is execution time.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28589#discussion_r2615925589


More information about the hotspot-dev mailing list