RFR: 8373069: RISC-V: implement GHASH intrinsic [v4]

Anjian Wen wenanjian at openjdk.org
Mon Dec 15 03:02:28 UTC 2025


On Sun, 14 Dec 2025 03:50:11 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

>> Anjian Wen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   modify format
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 3019:
> 
>> 3017:     assert(UseGHASHIntrinsics, "Must be");
>> 3018:     assert(UseZvbb, "need Zvbb extension support");
>> 3019:     assert(UseZvkg, "need GHASH instructions (Zvkg extension) support");
> 
> Do we need `UseZvbb` and  `UseZvkg` assertions here? `UseGHASHIntrinsics` should be enough as it depends on `UseZvbb` and  `UseZvkg`.

Thanks for pointing out. yes, it seems a little bit redundant, I'll try delete it and test it one more time for sure before update.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28548#discussion_r2617796611


More information about the hotspot-dev mailing list