RFR: 8373069: RISC-V: implement GHASH intrinsic [v4]

[Anjian Wen]

On Mon, 15 Dec 2025 01:35:51 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Anjian Wen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   modify format
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 3021:
> 
>> 3019:     assert(UseZvkg, "need GHASH instructions (Zvkg extension) support");
>> 3020: 
>> 3021:     __ align(CodeEntryAlignment);
> 
> Can you move this line to immediately before L3025? Like:
> 
>     __ align(CodeEntryAlignment);
>     address start = __ pc();
>     __ enter();
> 
> 
> Then it looks more obvious where we want to align the code. BTW: Seems CBC and CTR intrinsics need similar adjustment.

it seems most of the intrinsics use align func before stub_id, maybe we can keep it for now and discuss all of them later?

> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 3052:
> 
>> 3050:       __ vghsh_vv(partial_hash, hash_subkey, cipher_text);
>> 3051:       __ subi(blocks, blocks, 1);
>> 3052:       __ bnez(blocks, L_ghash_loop);
> 
> Please leave a new line after the loop.

Thanks, fixed!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28548#discussion_r2618904912
PR Review Comment: https://git.openjdk.org/jdk/pull/28548#discussion_r2618905299