RFR: 8373654: Test sources/TestNoNull should only run once
Aleksey Shipilev
shade at openjdk.org
Mon Dec 15 20:54:33 UTC 2025
On Mon, 15 Dec 2025 06:52:49 GMT, David Holmes <dholmes at openjdk.org> wrote:
> This test is checking for backsliding on the use of NULL in the hotspot source files. The test only needs to be run once per change but it is defined as a regular tier1 test which then gets run for each os-arch combination, plus product and debug, and then again with a bunch of flags in tier3. This is just a waste of resources. At a minimum we should make the test flagless so that it doesn't run in tier3, but we can also restrict it to a single platform.
>
> Before the change the test ran 27 times in tier1-3 in our CI. After it runs once.
>
> Thanks
`flagless` -- I agree!
`linux` and `amd64` -- as someone who re-runs this test on my M1 Mac to reproduce CI failures, I disagree!
`vm.debug` -- I am on the fence here, but probably fine to restrict it to debug only, as we expect most folks to run tests with debug VMs.
You might want to do this for other `sources/` tests?
-------------
PR Review: https://git.openjdk.org/jdk/pull/28818#pullrequestreview-3577715711
More information about the hotspot-dev
mailing list