RFR: 8373668: Add override keyword to *Klass classes [v2]

David Holmes dholmes at openjdk.org
Tue Dec 16 06:44:54 UTC 2025


On Mon, 15 Dec 2025 13:22:55 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Using override provides better visibility and compiler support for suspicious virtual methods. It makes it clears when reading a class header file if a new virtual interface is introduced or if it simply overridden.
>> 
>> Testing
>>  * GHA
>>  * Running tier1 on Oracle supported platforms
>
> Axel Boldt-Christmas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Whitespace changes

This all seems reasonable. I hope an IDE assisted with determining where override was needed, and virtual was not.

I think it would be good to see things marked final in the future as well.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28820#pullrequestreview-3581552256


More information about the hotspot-dev mailing list