RFR: 8372754: Add wrapper for <cstdlib> [v2]

[Thomas Schatzl]

On Mon, 15 Dec 2025 01:37:11 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this change that adds a HotSpot wrapper for <cstdlib>.  It also
>> includes the forbidden function declarations for functions declared there,
>> moving them from forbiddenFunctions.hpp and friends.
>> 
>> The AIX-specific workaround for its macro-based renaming of malloc/calloc is
>> also moved to this wrapper, so there is a single location for it. Also cleaned
>> it up a bit, based on further investigation of the problem.
>> 
>> Also changed uses of <cstdlib> and <stdlib.h> to include the wrapper instead.
>> There are still a couple of includes of <stdlib.h> in the hotspot directory,
>> because they can't use the hotspot wrapper: os/windows/include/jvm_md.h and
>> share/adlc/adlc.hpp.  I looked at removing the one in windows jvm_md.h, but
>> there are a lot of dependencies on that implicit include in non-HotSpot code.
>> 
>> While updating to use the wrapper, I also did a small amount of include
>> cleanup here and there.  The changes around immediate_aarch64.hpp are perhaps
>> a little less trivial than I should have made here.
>> 
>> Testing: mach5 tier1
>> 
>> This should probably be retested by aix port maintainer folks, although I
>> don't think I made any relevant changes since you last tested it.
>> 
>> This change also resolves:
>
> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into wrap-cstdlib
>  - add wrapper for <cstdlib>

Marked as reviewed by tschatzl (Reviewer).

src/hotspot/os/aix/libperfstat_aix.hpp line 36:

> 34: 
> 35: #include "cppstdlib/cstdlib.hpp"
> 36: #include <sys/types.h>

Maybe add a newline between the double-quoted and the angle-bracketed includes similar to other files.

-------------

PR Review: https://git.openjdk.org/jdk/pull/28562#pullrequestreview-3582289172
PR Review Comment: https://git.openjdk.org/jdk/pull/28562#discussion_r2622615151