RFR: 8373343: C2: verify AddP base input only set for heap addresses [v2]
Roland Westrelin
roland at openjdk.org
Wed Dec 17 14:06:48 UTC 2025
On Wed, 17 Dec 2025 03:00:34 GMT, Dean Long <dlong at openjdk.org> wrote:
>> `isa_oopptr()` is non null for all oops, array and instance.
>
> It seems like "dest" is always an oop here and we don't need to check isa_oopptr().
It is always an heap address. But when used at object creation time, it's not yet an oop. It only becomes one once it is initialized. For those `Store`s to the not yet initialized object, I don't think the base edge is needed (there can't be any safepoint until the object becomes an actual oop) and code elsewhere (`InitializeNode::capture_store()`) doesn't set the base input either.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28769#discussion_r2627200158
More information about the hotspot-dev
mailing list