Integrated: 8373654: Tests in sources/ should only run once
David Holmes
dholmes at openjdk.org
Wed Dec 17 22:18:05 UTC 2025
On Mon, 15 Dec 2025 06:52:49 GMT, David Holmes <dholmes at openjdk.org> wrote:
> This test is checking for backsliding on the use of NULL in the hotspot source files. The test only needs to be run once per change but it is defined as a regular tier1 test which then gets run for each os-arch combination, plus product and debug, and then again with a bunch of flags in tier3. This is just a waste of resources. At a minimum we should make the test flagless so that it doesn't run in tier3, but we can also restrict it to a single platform.
>
> Before the change the test ran 27 times in tier1-3 in our CI. After it runs once.
>
>
> EDIT: Updated to include both tests in sources/
>
> Thanks
This pull request has now been integrated.
Changeset: b3fab414
Author: David Holmes <dholmes at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/b3fab41460eabf253879d140b55b6b12036c7c10
Stats: 4 lines in 2 files changed: 4 ins; 0 del; 0 mod
8373654: Tests in sources/ should only run once
Reviewed-by: shade, lmesnik
-------------
PR: https://git.openjdk.org/jdk/pull/28818
More information about the hotspot-dev
mailing list