RFR: 8373343: C2: verify AddP base input only set for heap addresses [v2]

[Dean Long]

On Wed, 17 Dec 2025 14:04:04 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> The base input of `AddP` is expected to only be set for heap accesses
>> but I noticed some inconsistencies so I added an assert in the `AddP`
>> constructor and fixed issues that it caught. AFAFICT, the
>> inconsistencies shouldn't create issues.
>
> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - review
>  - review
>  - merge
>  - more
>  - more
>  - more
>  - undo
>  - exps

I ran testing and got one mysterious timeout in
java/net/httpclient/DurationOverflowTest.java#withPropertyConfig
Normally this test runs in seconds, but it timed out in 9 minutes.  It could be unrelated to your changes or even a test bug, but I couldn't find any previous timeout failures for this test.
Most of your changes look low-risk.  The change I'm most concerned about is in LoadKlassNode::Identity, when it returns the Address edge instead of Base.

-------------

PR Review: https://git.openjdk.org/jdk/pull/28769#pullrequestreview-3598064741