RFR: 8373343: C2: verify AddP base input only set for heap addresses [v2]

[Roland Westrelin]

On Thu, 18 Dec 2025 03:27:29 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - review
>>  - review
>>  - merge
>>  - more
>>  - more
>>  - more
>>  - undo
>>  - exps
>
> src/hotspot/share/opto/memnode.cpp line 2570:
> 
>> 2568:             assert(tkls2->offset() == 0, "not a load of java_mirror");
>> 2569: #endif
>> 2570:             return adr2->in(AddPNode::Address);
> 
> What should the value of adr2->in(AddPNode::Offset) be at this point? 0 or java_mirror_offset()?  Do we need to check it?

I added a couple asserts here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28769#discussion_r2635070902