RFR: 8373343: C2: verify AddP base input only set for heap addresses [v3]

[Dean Long]

On Fri, 19 Dec 2025 13:15:38 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> The base input of `AddP` is expected to only be set for heap accesses
>> but I noticed some inconsistencies so I added an assert in the `AddP`
>> constructor and fixed issues that it caught. AFAFICT, the
>> inconsistencies shouldn't create issues.
>
> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review

Let me run testing again before I approve final version.  2nd round of testing passed, but it was on an earlier version.

-------------

PR Review: https://git.openjdk.org/jdk/pull/28769#pullrequestreview-3600464325