RFR: 8374190: Convert ConcurrentHashTable atomic lists to use Atomic<T>
David Holmes
dholmes at openjdk.org
Tue Dec 23 06:12:51 UTC 2025
On Mon, 22 Dec 2025 07:29:55 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> Please review this change to ConcurrentHashTable to use `Atomic<Node*>` for
> the Node lists. Note that this does not complete the replacement of direct
> uses of AtomicAccess by that class; there's still one more group remaining.
>
> Testing: mach5 tier1-3
This all seems reasonable.
Thanks
src/hotspot/share/utilities/concurrentHashTable.hpp line 178:
> 176: // assignment, thus here we must cast const part away. Method is not static
> 177: // due to an assert.
> 178: void release_assign_node_ptr(const Atomic<Node*>* dst, Node* node) const;
The `const` part of the comment no longer seems relevant.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28951#pullrequestreview-3606620703
PR Review Comment: https://git.openjdk.org/jdk/pull/28951#discussion_r2641999957
More information about the hotspot-dev
mailing list