RFR: 8349211: Add support for intrusive trees to the utilities red-black tree
Casper Norrbin
cnorrbin at openjdk.org
Mon Feb 3 11:26:19 UTC 2025
Hi everyone,
The recently integrated red-black tree can be made more flexible by adding support of intrusive trees. In an intrusive tree, the user has full control over node allocation and placement instead of having the tree manage it internally.
Two key changes enable this feature:
1. Nodes can now be created outside of the tree's internal allocation mechanism, enabling users to allocate and prepare nodes before inserting them into the tree.
2. Cursors have been added to simplify navigation and iteration over the tree. These cursors are when inserting and removing nodes in an intrusive tree, where the internal tree allocator is not used. Additionally, cursors enable iteration over the tree and provide a convenient way to access node values.
Many of the auxiliary tree functions have been updated to use these new features, resulting in simplified and cleaned-up code. More tests have also been added to cover both new and existing functionality.
A simple example of you could use an intrusive tree is found below:
```c++
struct MyIntrusiveStructure {
Node node; // The tree node is part of an external structure
int data;
MyIntrusiveStructure(int data, Node node) : node(node), data(data) {}
Node* get_node() { return &node; }
static MyIntrusiveStructure* cast_to_self(Node* node) { return (MyIntrusiveStructure*)node; }
};
Tree my_intrusive_tree;
Cursor insert_cursor = my_intrusive_tree.cursor_find(0);
Node insert_node = Node(0);
// Custom allocation here is just malloc
MyIntrusiveStructure* place = (MyIntrusiveStructure*)os::malloc(sizeof(MyIntrusiveStructure), mtTest);
new (place) MyIntrusiveStructure(0, insert_node);
my_intrusive_tree.insert_at_cursor(place->get_node(), insert_cursor);
Cursor find_cursor = my_intrusive_tree.cursor_find(0);
int found_data = MyIntrusiveStructure::cast_to_self(find_cursor.node())->data;
Please let me know any feedback or concerns!
-------------
Commit messages:
- intrusive red-black tree
Changes: https://git.openjdk.org/jdk/pull/23416/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23416&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8349211
Stats: 669 lines in 3 files changed: 463 ins; 135 del; 71 mod
Patch: https://git.openjdk.org/jdk/pull/23416.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23416/head:pull/23416
PR: https://git.openjdk.org/jdk/pull/23416
More information about the hotspot-dev
mailing list