RFR: 8349083: Factor out filename handling code from logging

David Holmes dholmes at openjdk.org
Tue Feb 4 10:40:12 UTC 2025


On Tue, 4 Feb 2025 10:37:06 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> The "timestamp" comes from `os::javaTimeMillis()`, it is not the VM start time. 
>> 
>> Unified logging captures the VM start time and uses it from its filename substitution.
>> 
>> 
>>    output = new LogFileOutput(name, _vm_start_time);
>
> Sorry then I have misunderstood the refactoring of this. I was expecting "%t" to always mean the VM start time - otherwise what time is it?

The time the file was created? The time the file name was "constructed"? Or ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23410#discussion_r1940919876


More information about the hotspot-dev mailing list