RFR: 8348349: Refactor CDSConfig::is_dumping_heap() [v3]
Ioi Lam
iklam at openjdk.org
Tue Feb 4 16:11:19 UTC 2025
On Thu, 23 Jan 2025 22:23:45 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Merge branch 'master' into 8348349-refactor-heap-shared-can-write
>> - @matias9927 comment
>> - Fixed whitespace
>> - Fixed 32-bit build
>> - 8348349: Refactor HeapShared::can_write()
>
> Change looks good, thanks for the cleanup! I have some small comments that you can address if you think it's valuable:
Thanks @matias9927 and @calvinccheung for the review
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23249#issuecomment-2634421807
More information about the hotspot-dev
mailing list