RFR: 8349211: Add support for intrusive trees to the utilities red-black tree [v2]

Casper Norrbin cnorrbin at openjdk.org
Wed Feb 5 14:35:13 UTC 2025


On Mon, 3 Feb 2025 19:39:36 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Casper Norrbin has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - reduced diff
>>  - 0-sized value
>
> src/hotspot/share/utilities/rbTree.hpp line 71:
> 
>> 69:     const K& key() const { return _key; }
>> 70:     V& val() { return _value; }
>> 71:     V& val() const { return _value; }
> 
> Hmm, this doesn't seem quite right. Why can't we have a `const` method returning a `const`  value anymore?

Oops, fixed now :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23416#discussion_r1943052390


More information about the hotspot-dev mailing list