RFR: 8337217: Port VirtualMemoryTracker to use VMATree [v20]

[Afshin Zafari]

On Tue, 4 Feb 2025 13:56:50 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix in shendoahCardTable
>
> src/hotspot/share/nmt/virtualMemoryTracker.cpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2013, 2025, Oracle and/or its affiliates. All rights reserved.
> 
> Weird, another copyright issue here

Fixed.

> src/hotspot/share/nmt/virtualMemoryTracker.hpp line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2013, 2024, Oracle and/or its affiliates. All rights reserved.
>> 3:  * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
> 
> Incorrect copyright addition.

Fixed.

> src/hotspot/share/nmt/virtualMemoryTracker.hpp line 27:
> 
>> 25: 
>> 26: #ifndef NMT_VIRTUALMEMORYTRACKER_HPP
>> 27: #define NMT_VIRTUALMEMORYTRACKER_HPP
> 
> This shouldn't be changed???

Done.

> src/hotspot/share/nmt/vmatree.cpp line 81:
> 
>> 79:       stA.out.set_tag(tag);
>> 80:       LEQ_A.state.out.set_tag(tag);
>> 81:       stB.in.set_tag(tag);
> 
> Commented out assert and an addition I'm trying to wrap my head around. Does this fix a pre-existing bug? If so, this should be a separate PR for mainline before this PR is integrated.

Removed the commented out line.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1945265638
PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1945265403
PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1945265243
PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1945265068