RFR: 8349525: RBTree: provide leftmost, rightmost, and a simple way to print trees [v2]

Thomas Stuefe stuefe at openjdk.org
Fri Feb 7 15:40:14 UTC 2025


On Fri, 7 Feb 2025 09:09:04 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   feedback johan
>
> src/hotspot/share/utilities/rbTree.hpp line 48:
> 
>> 46: class RBTree {
>> 47:   friend class RBTreeTest;
>> 48:   typedef RBTree<K, V, COMPARATOR, ALLOCATOR> TreeType;
> 
> I'm referring to this being `TreeType` and not only `Tree`, same with `Node`.

Oh I see. In this case, I would prefer the more descriptive "Type", even though the upper case T in Tree indicates that this would probably be a type, not a variable name.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23486#discussion_r1946721956


More information about the hotspot-dev mailing list