RFR: 8349525: RBTree: provide leftmost, rightmost, and a simple way to print trees [v2]

Thomas Stuefe stuefe at openjdk.org
Fri Feb 7 15:40:14 UTC 2025


On Fri, 7 Feb 2025 11:14:00 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   feedback johan
>
> test/hotspot/gtest/utilities/test_rbtree.cpp line 424:
> 
>> 422:       n = rbtree.leftmost();
>> 423:       ASSERT_EQ(n->key(), min);
>> 424:       n->set_val(1);
> 
> Why are the node's values set to 1?

I wanted to have a modifying call on Node*, just to make sure its non-const (paranoid I know)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23486#discussion_r1946726213


More information about the hotspot-dev mailing list