RFR: 8349652: Rewire nmethod oop load barriers
Stefan Karlsson
stefank at openjdk.org
Mon Feb 10 12:58:12 UTC 2025
On Mon, 10 Feb 2025 12:23:12 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:
> Good. Many thanks to you. I am looking forward to this change being integrated. My PR #21276, which builds on top of this change, now passes jtreg with -XX:+UseZGC.
Thanks and thanks for verifying that this fits with your changes!
> src/hotspot/share/gc/shared/barrierSetNMethod.hpp line 29:
>
>> 27:
>> 28: #include "memory/allocation.hpp"
>> 29: #include "oops/oopsHierarchy.hpp"
>
> This is probably an unnecessary include
It's needed because I use the type `oop`. I got concrete compilation errors when Shenandoah was compiled and adding this include fixes those issues.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23512#issuecomment-2647908012
PR Review Comment: https://git.openjdk.org/jdk/pull/23512#discussion_r1949006110
More information about the hotspot-dev
mailing list