RFR: JDK-8216437 : PPC64: Add intrinsic for GHASH algorithm [v19]

Martin Doerr mdoerr at openjdk.org
Mon Feb 10 13:20:14 UTC 2025


On Mon, 10 Feb 2025 13:15:15 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> The problem is that you're overwriting it below which should not be done:
>> 
>>     __ vxor(vZero, vTmp4, vTmp10);
>>     __ vmr(vState, vZero);
>> 
>> Why not `__ vxor(vState, vTmp4, vTmp10);`?
>
> We are storing the result in each operation into vState to re use in the next operation using 
> __ vxor(vH, vH, vState);
> This is similar to https://github.com/openjdk/jdk/blob/c9cadbd23fb13933b8968f283d27842cd35f8d6f/src/java.base/share/classes/com/sun/crypto/provider/GHASH.java#L118

That doesn't answer "Why not __ vxor(vState, vTmp4, vTmp10);?"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20235#discussion_r1949038200


More information about the hotspot-dev mailing list