RFR: 8349211: Add support for intrusive trees to the utilities red-black tree [v7]

Johan Sjölen jsjolen at openjdk.org
Mon Feb 10 18:22:21 UTC 2025


On Mon, 10 Feb 2025 18:13:49 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   empty base optimization reference
>
> src/hotspot/share/utilities/rbTree.hpp line 150:
> 
>> 148:   // If a cursor is valid (valid() == true) it points somewhere in the tree.
>> 149:   // If the cursor points to an existing node (found() == true), node() can be used to access that node,
>> 150:   // Otherwise nullptr is returned, regardless if the node is valid or not.
> 
> Style: "nullptr" should be "null" here.

"Otherwise", but the above line has a comma.  What can be used to access that node? You don't say :-).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23416#discussion_r1949654441


More information about the hotspot-dev mailing list