RFR: 8349686: [s390x] C1: Improve Class.isInstance intrinsic [v2]

[Amit Kumar]

On Tue, 11 Feb 2025 08:11:51 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   optimize branching
>
> src/hotspot/cpu/s390/c1_Runtime1_s390.cpp line 601:
> 
>> 599:       // Get the Klass* into Z_ARG3
>> 600:       Register klass = Z_ARG3 , obj = Z_ARG2, result = Z_RET;
>> 601:       Register temp0 = Z_ARG4, temp1 = Z_ARG5, temp2 = Z_tmp_1, temp3 = Z_tmp_2;
> 
> Suggestion:
> 
>       Register temp0 = Z_ARG4, temp1 = Z_ARG5, temp2 = Z_R11, temp3 = Z_R12;
> 
> Aliasing `temp2` to `Z_tmp_1` is just too confusing to the reader.

Updated. 

`Z_tmp_1` and `Z_tmp_2` refers to `Z_R10` and `Z_R11` respectively, So I have update the patch according to that. 


constexpr Register Z_tmp_1 =  Z_R10;
constexpr Register Z_tmp_2 =  Z_R11;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23535#discussion_r1950421440