RFR: 8349686: [s390x] C1: Improve Class.isInstance intrinsic [v3]

Andrew Haley aph at openjdk.org
Tue Feb 11 08:39:11 UTC 2025


On Tue, 11 Feb 2025 08:33:42 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> s390x implementation for Class.isInstance intrinsic. 
>> 
>> Tier1 test on release & fastdebug vm are clean with flag: `-XX:-UseSecondarySupersCache -XX:+UseSecondarySupersTable -XX:+VerifySecondarySupers -XX:+StressSecondarySupers`. 
>> 
>> Benchmark results will be updated soon.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   suggestions from Andrew

src/hotspot/cpu/s390/c1_Runtime1_s390.cpp line 650:

> 648:       // lookup_secondary_supers_table_var return 0 on success and 1 on failure.
> 649:       // but this method returns 0 on failure and 1 on success.
> 650:       // so we have to inverse the result we got from lookup_secondary_supers_table_var.

Suggestion:

      // so we have to invert the result from lookup_secondary_supers_table_var.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23535#discussion_r1950429772


More information about the hotspot-dev mailing list