RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v5]
Bhavana Kilambi
bkilambi at openjdk.org
Tue Feb 11 10:43:22 UTC 2025
On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi <duke at openjdk.org> wrote:
>> By using the aarch64 vector registers the speed of the computation of the ML-DSA algorithms (key generation, document signing, signature verification) can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
>
> Adding comments + some code reorganization
src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 2618:
> 2616: INSN(smaxp, 0, 0b101001, false); // accepted arrangements: T8B, T16B, T4H, T8H, T2S, T4S
> 2617: INSN(sminp, 0, 0b101011, false); // accepted arrangements: T8B, T16B, T4H, T8H, T2S, T4S
> 2618: INSN(sqdmulh,0, 0b101101, false); // accepted arrangements: T4H, T8H, T2S, T4S
Hi, not a comment on the algorithm itself but you might have to add these new instructions in the gtest for aarch64 here - test/hotspot/gtest/aarch64/aarch64-asmtest.py and use this file to generate test/hotspot/gtest/aarch64/asmtest.out.h which would contain these newly added instructions.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23300#discussion_r1950610623
More information about the hotspot-dev
mailing list