RFR: 8349851: RISCV: Call VM leaf can use movptr2

Fei Yang fyang at openjdk.org
Wed Feb 12 03:00:18 UTC 2025


On Tue, 11 Feb 2025 17:26:28 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

> Hi, please consider.
> 
> There should be a small speed up to vm leafs.
> We can scratch t2 here as we just pushed it. (maybe I should have used t0)
> 
> Passes t1
> 
> /Robbin

src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 797:

> 795:   push_reg(RegSet::of(t1, xmethod), sp);   // push << t1 & xmethod >> to sp
> 796: 
> 797:   movptr(t1, entry_point, offset, t2);

Personally, I prefer `movptr2(t1, entry_point, offset, t0);` which will be consistent with the one in the preceding assembler routine `MacroAssembler::emit_static_call_stub()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23565#discussion_r1951907146


More information about the hotspot-dev mailing list