RFR: 8336042: Caller/callee param size mismatch in deoptimization causes crash

[Fei Yang]

On Wed, 12 Feb 2025 20:24:05 GMT, Dean Long <dlong at openjdk.org> wrote:

> > FYI: `test/hotspot/jtreg/compiler/jsr292/MHDeoptTest.java` and hs-tier1 test good on linux-riscv64 with fastdebug build.
> 
> I good sanity check is to remove the fix in deoptimization.cpp and see if the new test triggers the new asserts.

Yeah! The new test triggers if I revert the fix.

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (/home/ubuntu/jdk/src/hotspot/cpu/riscv/abstractInterpreter_riscv.cpp:145), pid=95195, tid=95217
#  assert(locals >= interpreter_frame->sender_sp() + max_locals - 1) failed: bad placement
#
# JRE version: OpenJDK Runtime Environment (25.0) (fastdebug build 25-internal-adhoc.ubuntu.jdk)
# Java VM: OpenJDK 64-Bit Server VM (fastdebug 25-internal-adhoc.ubuntu.jdk, mixed mode, sharing, compressed oops, compressed class ptrs, g1 gc, linux-riscv64)
# Problematic frame:
# V  [libjvm.so+0x2e1204]  AbstractInterpreter::layout_activation(Method*, int, int, int, int, int, int, frame*, frame*, bool, bool)+0x3fa
#
# Core dump will be written. Default location: Core dumps may be processed with "/usr/share/apport/apport -p%p -s%s -c%c -d%d -P%P -u%u -g%g -- %E" (or dumping to /home/ubuntu/jdk/build/linux-riscv64-
server-fastdebug/test-support/jtreg_test_hotspot_jtreg_compiler_jsr292_MHDeoptTest_java/scratch/0/core.95195)
#
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp
#

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23557#issuecomment-2655355838