RFR: 8347833: CrashOnOutOfMemory should stop GC threads before HeapDumpOnOutOfMemoryError [v2]

[Fairoz Matte]

On Fri, 14 Feb 2025 05:34:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Fairoz Matte has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Aditional work on review comments
>
> src/hotspot/share/utilities/debug.cpp line 272:
> 
>> 270:     VMError::report_java_out_of_memory(message, HeapDumpOnOutOfMemoryError, CrashOnOutOfMemoryError);
>> 271: 
>> 272:     if (CrashOnOutOfMemoryError) {
> 
> The `if (CrashOnOutOfMemoryError)` is unreachable code as `report_java_out_of_memory` already aborted.

yes, it can be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23519#discussion_r1956972198