RFR: 8349211: Add support for intrusive trees to the utilities red-black tree [v9]
Thomas Stuefe
stuefe at openjdk.org
Sun Feb 16 07:46:11 UTC 2025
On Mon, 3 Feb 2025 19:39:36 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> renamed non-value upsert to insert
>
> src/hotspot/share/utilities/rbTree.hpp line 71:
>
>> 69: const K& key() const { return _key; }
>> 70: V& val() { return _value; }
>> 71: V& val() const { return _value; }
>
> Hmm, this doesn't seem quite right. Why can't we have a `const` method returning a `const` value anymore?
Yes. Please give us const and non-const access for node access.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23416#discussion_r1940987593
More information about the hotspot-dev
mailing list