RFR: 8342769: HotSpot Windows/gcc port is broken [v16]

[David Holmes]

On Mon, 17 Feb 2025 08:27:56 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Several areas in HotSpot are broken in the gcc port. These, with the exception of 1 rather big oversight within SharedRuntime::frem and SharedRuntime::drem, are all minor correctness issues within the code. These mostly can be fixed with simple changes to the code. Note that I am not sure whether the SharedRuntime::frem and SharedRuntime::drem fix is correct. It may be that they can be removed entirely
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:
> 
>  - CAST_FROM_FN_PTR in os_windows.cpp
>  - Merge branch 'master' into hotspot
>  - Merge branch 'openjdk:master' into hotspot
>  - _WINDOWS && AARCH64 in sharedRuntime.hpp
>  - AARCH64 in sharedRuntimeRem.cpp
>  - Refactor sharedRuntime.cpp
>  - CAST_FROM_FN_PTR in os_windows.cpp
>  - Merge branch 'openjdk:master' into hotspot
>  - fmod_winarm64 in sharedRuntime.cpp
>  - fmod_winarm64 in sharedRuntimeRem.cpp
>  - ... and 19 more: https://git.openjdk.org/jdk/compare/5e9d72e2...3f9ca206

Latest changes seem fine too. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21627#pullrequestreview-2620782920