RFR: 8350093: RISC-V: java/math/BigInteger/LargeValueExceptions.java timeout with COH

Hamlin Li mli at openjdk.org
Mon Feb 17 13:56:14 UTC 2025


On Fri, 14 Feb 2025 16:00:40 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 5486:
>> 
>>> 5484:   const Register jdx = tmp1;
>>> 5485: 
>>> 5486:   if (AvoidUnalignedAccesses) {
>> 
>> If `AvoidUnalignedAccesses == false`, it will go through all alignment code? But seems original code will not go through this alignment when `AvoidUnalignedAccesses == false`.
>
> Hi, not sure if I understand the question correctly. This only affects platforms where `AvoidUnalignedAccesses` is true.
> It does not make a difference on platforms with fast misaligned accesses (which means `AvoidUnalignedAccesses == false`).

Ah, I think I red the code wrong, it's good.
I thought you closed the curly brace earlier than before.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23631#discussion_r1958279785


More information about the hotspot-dev mailing list