RFR: 8280682: Refactor AOT code source validation checks [v2]

Ashutosh Mehra asmehra at openjdk.org
Tue Feb 18 05:24:10 UTC 2025


On Fri, 14 Feb 2025 19:21:32 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> This changset refactors CDS class paths and module paths validation code into a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and classLoaderExt.[c|h]pp to aotCodeSource.[c|h]pp. CDS dependencies have been removed from `classLoader.cpp`. More refactoring could be done, such as removing `classLoaderExt.cpp`, in a future RFE.
>> 
>> Passed tiers 1 - 5 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @iklam and @ashu-mehra comment

Marked as reviewed by asmehra (Committer).

Just one more comment, rest looks good.

src/hotspot/share/runtime/threads.cpp line 27:

> 25:  */
> 26: 
> 27: #include "cds/aotCodeSource.hpp"

Why is this include needed?

-------------

PR Review: https://git.openjdk.org/jdk/pull/23476#pullrequestreview-2622461930
PR Comment: https://git.openjdk.org/jdk/pull/23476#issuecomment-2664635612
PR Review Comment: https://git.openjdk.org/jdk/pull/23476#discussion_r1959077605


More information about the hotspot-dev mailing list