RFR: 8350182: [s390x] Relativize locals in interpreter frames

Amit Kumar amitkumar at openjdk.org
Tue Feb 18 11:40:12 UTC 2025


On Tue, 18 Feb 2025 11:32:50 GMT, Andrew Haley <aph at openjdk.org> wrote:

> Should this be a function?

This is similar to [ppc ijava_idx](https://github.com/openjdk/jdk/blob/885be2efa6b1359a7c7ab36882e19a7eaba77fb3/src/hotspot/cpu/ppc/frame_ppc.hpp#L283C1-L285C58)

> Also, names starting with _ aren't common in HotSpot code, except for fields in C++ objects.

I did it for keeping the parity with: 

#define _z_ijava_state_neg(_component) \
         (int) (-frame::z_ijava_state_size + offset_of(frame::z_ijava_state, _component))

Do you want me to revert it ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23660#discussion_r1959568305


More information about the hotspot-dev mailing list