RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v5]

[Andrew Dinn]

On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi <duke at openjdk.org> wrote:

>> By using the aarch64 vector registers the speed of the computation of the ML-DSA algorithms (key generation, document signing, signature verification) can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding comments + some code reorganization

src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 2594:

> 2592:     guarantee(T != T1Q && T != T1D, "incorrect arrangement");                           \
> 2593:     if (!acceptT2D) guarantee(T != T2D, "incorrect arrangement");                       \
> 2594:     if (strcmp(#NAME, "sqdmulh") == 0) guarantee(T != T8B && T != T16B, "incorrect arrangement");   \

Suggestion:

I think it might be better to change this test from a strcmp call to (opc2 == 0b101101). The strcmp test is clearer to a reader of the code but the call may not be guaranteed to be compiled out at build time while the latter will.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23300#discussion_r1959758334