RFR: 8350258: AArch64: Client build fails after JDK-8347917

Dean Long dlong at openjdk.org
Wed Feb 19 00:49:56 UTC 2025


On Tue, 18 Feb 2025 22:42:18 GMT, Dmitry Chuyko <dchuyko at openjdk.org> wrote:

> The location for rfp should be set in in the register map. In particular, it wasn't set in frame::sender_for_interpreter_frame() if neither C2 nor JVMCI were included.
> 
> COMPILER1_OR_COMPILER2 condition is used instead of COMPILER2_OR_JVMCI, which also covers INCLUDE_JVMCI case.

src/hotspot/cpu/aarch64/frame_aarch64.cpp line 512:

> 510: #if COMPILER1_OR_COMPILER2
> 511:   if (map->update_map()) {
> 512:     update_map_with_saved_link(map, (intptr_t**) addr_at(link_offset));

Is it correct that this is only needed when PreserveFramePointer is false, and it's harmless to do when PreserveFramePointer is true?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23682#discussion_r1960788519


More information about the hotspot-dev mailing list