RFR: 8350303: ARM32: StubCodeGenerator::verify_stub(StubGenStubId) failed after JDK-8343767

[Hao Sun]

On Wed, 19 Feb 2025 09:43:50 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> We encountered the following runtime error on ARM32:
>> 
>> 
>> assert(StubRoutines::stub_to_blob(stub_id) == blob_id()) failed: wrong blob initial for generation of stub atomic_add
>> 
>> 
>> I suppose it might be a mistake in JDK-8343767. `atomic_add` stub belongs to **initial** stubs, but it is set as **compiler** stub in JDK-8343767.
>> 
>> Note that only ARM32 is affected as only ARM32 defines this stub.
>> 
>> Tests: cross-build for `arm32, ppc64, riscv64, s390x` passed. Tier1~3 passed on Linux/AArch64 and Linux/x86_64
>
> src/hotspot/share/runtime/stubDeclarations.hpp line 556:
> 
>> 554:   do_entry(initial, fence, fence_entry, fence_entry)                    \
>> 555:   do_stub(initial, atomic_add)                                         \
>> 556:   do_entry(initial, atomic_add, atomic_add_entry, atomic_add_entry)  \
> 
> Indenting for trailing `` is not tidy.

yes. will update soon. Thanks for pointing this out.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23687#discussion_r1961328494