RFR: 8350182: [s390x] Relativize locals in interpreter frames

Andrew Haley aph at openjdk.org
Wed Feb 19 11:04:53 UTC 2025


On Wed, 19 Feb 2025 02:52:40 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> There is no good reason to use a macro here. If a function can be a function, and this one can, let it be one. However, there is no reason to change anything else. Leave that for a "macros to functions" patch some other day.
>
> I could only achieve this implementation: [macro to method](https://github.com/offamitkumar/jdk/commit/a4a3908288c8c0f518ad263062acd504cd6b7d3c), which looks dirty.

Fair enough. It's not worth doing that, and what you do here does match PPC. OK.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23660#discussion_r1961471462


More information about the hotspot-dev mailing list