RFR: 8350303: ARM32: StubCodeGenerator::verify_stub(StubGenStubId) failed after JDK-8343767 [v2]

[Andrew Dinn]

On Wed, 19 Feb 2025 10:04:55 GMT, Hao Sun <haosun at openjdk.org> wrote:

>> We encountered the following runtime error on ARM32:
>> 
>> 
>> assert(StubRoutines::stub_to_blob(stub_id) == blob_id()) failed: wrong blob initial for generation of stub atomic_add
>> 
>> 
>> I suppose it might be a mistake in JDK-8343767. `atomic_add` stub belongs to **initial** stubs, but it is set as **compiler** stub in JDK-8343767.
>> 
>> Note that only ARM32 is affected as only ARM32 defines this stub.
>> 
>> Tests: cross-build for `arm32, ppc64, riscv64, s390x` passed. Tier1~3 passed on Linux/AArch64 and Linux/x86_64
>
> Hao Sun has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix code style

Marked as reviewed by adinn (Reviewer).

Yes, this fix is needed. atomic_add is only used in linux-arm-specific code and is needed during VM startup. It was moved into the compiler blob by mistake and hsodl really be declared as an initial stub.

-------------

PR Review: https://git.openjdk.org/jdk/pull/23687#pullrequestreview-2626918850
PR Comment: https://git.openjdk.org/jdk/pull/23687#issuecomment-2668758216