RFR: 8350258: AArch64: Client build fails after JDK-8347917

Dean Long dlong at openjdk.org
Wed Feb 19 23:59:52 UTC 2025


On Tue, 18 Feb 2025 22:42:18 GMT, Dmitry Chuyko <dchuyko at openjdk.org> wrote:

> The location for rfp should be set in in the register map. In particular, it wasn't set in frame::sender_for_interpreter_frame() if neither C2 nor JVMCI were included.
> 
> COMPILER1_OR_COMPILER2 condition is used instead of COMPILER2_OR_JVMCI, which also covers INCLUDE_JVMCI case.

I think @vnkozlov is right.  I don't see where COMPILER1_OR_COMPILER2 is true for JVMCI.  Should we use COMPILER1 || COMPILER2_OR_JVMCI, or remove the #if and instead guard with !PreserveFramePointer?

-------------

Changes requested by dlong (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23682#pullrequestreview-2628245608


More information about the hotspot-dev mailing list