RFR: 8348426: Generate binary file for -XX:AOTMode=record -XX:AOTConfiguration=file [v5]

Ioi Lam iklam at openjdk.org
Thu Feb 20 00:15:22 UTC 2025


On Tue, 18 Feb 2025 22:20:17 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @calvinccheung comments
>
> src/hotspot/share/cds/cdsConfig.cpp line 661:
> 
>> 659: 
>> 660: bool CDSConfig::is_loading_heap() {
>> 661:   return ArchiveHeapLoader::is_in_use();
> 
> Blank line removed by accident?

Fixed.

> src/hotspot/share/cds/cdsConfig.hpp line 138:
> 
>> 136:   static void stop_using_full_module_graph(const char* reason = nullptr) NOT_CDS_JAVA_HEAP_RETURN;
>> 137: 
>> 138: 
> 
> Blank line revmoved by accident?

There were two empty lines, so I removed one of them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23484#discussion_r1962560201
PR Review Comment: https://git.openjdk.org/jdk/pull/23484#discussion_r1962560299


More information about the hotspot-dev mailing list