RFR: 8280682: Refactor AOT code source validation checks [v2]
Calvin Cheung
ccheung at openjdk.org
Thu Feb 20 00:23:55 UTC 2025
On Wed, 19 Feb 2025 22:37:57 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> test/hotspot/jtreg/runtime/cds/appcds/BootClassPathMismatch.java line 243:
>>
>>> 241: * No error - bootclasspath can be appended during runtime if no -cp is specified.
>>> 242: */
>>> 243: public void testBootClassPathAppend() throws Exception {
>>
>> A refactoring should not be introducing new test cases. Did you refactor and enhance?
>
> This is a missing testcase and works the same before and after refactoring.
I needed to exclude the new test from running in the dynamic archive mode because there's no -cp specified during dumping. Otherwise, the test fails with`java.lang.RuntimeException: test.dynamic.dump is not supported with an empty classpath while the classlist is not empty`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23476#discussion_r1962568623
More information about the hotspot-dev
mailing list