RFR: 8280682: Refactor AOT code source validation checks [v4]

Vladimir Kozlov kvn at openjdk.org
Thu Feb 20 00:38:54 UTC 2025


On Thu, 20 Feb 2025 00:18:36 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> This changset refactors CDS class paths and module paths validation code into a new class `AOTCodeSource` and related class `AOTCodeSourceConfig`. Code has been moved from filemap.[c|h]pp, classLoader.[c|h]pp, and classLoaderExt.[c|h]pp to aotCodeSource.[c|h]pp. CDS dependencies have been removed from `classLoader.cpp`. More refactoring could be done, such as removing `classLoaderExt.cpp`, in a future RFE.
>> 
>> Passed tiers 1 - 5 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   new test case in BootClassPathMismatch.java is not applicable to dynamic archive

Passing by comment. We touched it on recent Leyden meeting. The name "AOTCodeSource" is very confusing. Especially when we start caching AOT compiled code. Can we rename it to avoid confusion?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23476#issuecomment-2670095758


More information about the hotspot-dev mailing list