RFR: 8349686: [s390x] C1: Improve Class.isInstance intrinsic [v8]

Andrew Haley aph at openjdk.org
Thu Feb 20 09:45:56 UTC 2025


On Fri, 14 Feb 2025 14:57:25 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> s390x implementation for Class.isInstance intrinsic. 
>> 
>> Tier1 test on release & fastdebug vm are clean with flag: `-XX:-UseSecondarySupersCache -XX:+UseSecondarySupersTable -XX:+VerifySecondarySupers -XX:+StressSecondarySupers`. 
>> 
>> Benchmark results will be updated soon.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove frame requirement

src/hotspot/cpu/s390/macroAssembler_s390.cpp line 3674:

> 3672:                                                    Register r_temp2,
> 3673:                                                    Register r_temp3) {
> 3674:   assert_different_registers(r_sub_klass, r_super_klass, r_result, r_temp1, r_temp2, r_temp3, Z_R0_scratch);

Suggestion:

  assert_different_registers(r_sub_klass, r_super_klass, r_result, r_temp1, r_temp2, r_temp3);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23535#discussion_r1963218531


More information about the hotspot-dev mailing list