RFR: 8349686: [s390x] C1: Improve Class.isInstance intrinsic [v8]
Amit Kumar
amitkumar at openjdk.org
Thu Feb 20 10:50:57 UTC 2025
On Thu, 20 Feb 2025 09:43:24 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove frame requirement
>
> src/hotspot/cpu/s390/macroAssembler_s390.cpp line 3674:
>
>> 3672: Register r_temp2,
>> 3673: Register r_temp3) {
>> 3674: assert_different_registers(r_sub_klass, r_super_klass, r_result, r_temp1, r_temp2, r_temp3, Z_R0_scratch);
>
> Suggestion:
>
> assert_different_registers(r_sub_klass, r_super_klass, r_result, r_temp1, r_temp2, r_temp3);
But we are still using Z_R0, to resize the frame, at line 3708 and 3718.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23535#discussion_r1963327400
More information about the hotspot-dev
mailing list