RFR: 8346916: [REDO] align_up has potential overflow
Casper Norrbin
cnorrbin at openjdk.org
Thu Feb 20 10:53:26 UTC 2025
Hi everyone,
The `align_up` function can potentially overflow, resulting in undefined behavior. Most use cases rely on the assumption that aligned_result >= original. To address this, I've added an assertion to verify this condition.
The original PR (#20808) missed cases where overflow checks already existed, so I've now went through usages of `align_up` and found the places with explicit checks. Most notably, #23168 added `align_up_or_null` to metaspace, but this function is also useful elsewhere. Given this, I relocated it to `align.hpp`, alongside the rest of the alignment functions.
Additionally, I've created `align_up_or_min`, which behaves similarly to the original align_up but handles overflows predictably across all integer types. This new function is used in the locations where overflow checks already exist, providing a safer alternative.
-------------
Commit messages:
- align_up assert
Changes: https://git.openjdk.org/jdk/pull/23711/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23711&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8346916
Stats: 87 lines in 6 files changed: 58 ins; 21 del; 8 mod
Patch: https://git.openjdk.org/jdk/pull/23711.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23711/head:pull/23711
PR: https://git.openjdk.org/jdk/pull/23711
More information about the hotspot-dev
mailing list