RFR: 8350258: AArch64: Client build fails after JDK-8347917

[Vladimir Kozlov]

On Wed, 19 Feb 2025 23:57:34 GMT, Dean Long <dlong at openjdk.org> wrote:

>> The location for rfp should be set in in the register map. In particular, it wasn't set in frame::sender_for_interpreter_frame() if neither C2 nor JVMCI were included.
>> 
>> COMPILER1_OR_COMPILER2 condition is used instead of COMPILER2_OR_JVMCI, which also covers INCLUDE_JVMCI case.
>
> I think @vnkozlov is right.  I don't see where COMPILER1_OR_COMPILER2 is true for JVMCI.  Should we use COMPILER1 || COMPILER2_OR_JVMCI, or remove the #if and instead guard with !PreserveFramePointer?

I was about suggest to add comment to avoid confusion but then I thought what @dean-long suggested is better and don't need comment:

#if defined(COMPILER1) || COMPILER2_OR_JVMCI
``` 

We already use such condition: [threads.cpp#L727](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/threads.cpp#L727)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23682#issuecomment-2672873577